[flatpak] multiple issues when running on flatpak

[JonnyCodewalker]

When running the flatpak version 3.6.0 or while running master as of 9925ef5
the following error appears when starting the application:

╰─>  flatpak run com.github.paolostivanin.OTPClient 
[WARNING] your operating system's memlock limit may be too low for you (current value: 8388608 bytes).
This may cause issues when importing third parties databases or dealing with tens of tokens.
For information on how to increase the memlock value, please have a look at https://github.com/paolostivanin/OTPClient/wiki/Secure-Memory-Limitations
couldn't lock 16384 bytes of memory (secret_file_backend): Cannot allocate memory
╰─[SIGTERM]> 

No discernible impact on usability, the application functions as expected besides the error message.

Happens on:

• Flathub flatpak (3.6.0) on Fedora 40
• Self compiled master on Fedora 40 @ toolbx

[paolostivanin]

Adding other issues from an e-mail I've received:

1. if the DB is not ~/.var/app/com.github.paolostivanin.OTPClient/data/otpclient-db.enc, then OTPClient won't open, even if I choose another DB in the same directory. If it's elsewhere and I've even given it access via flatpak override com.github.paolostivanin.OTPClient --filesystem=... it still doesn't work.
2. no changes to any settings take effect. For some I can change a setting and for others not, but nothing sticks.
3. if I change to another DB after opening the default it does update otpclient.cfg with the new DB information, but that gets ignored the next time it starts up.

[JonnyCodewalker]

Another thing I just realised, on my Flatpak installation the warning I get ( v 4.02) is, I am pretty sure, a false positive. The secmem limit is set to 8192 which according to the documentation should be more than enough (~20 tokens in the vault).

I think the issue is that when it can't lock memory it always assumes that the limit is to low. Minor point, but it could lead to confusion.

[paolostivanin]

Hello,
I've updated the wiki since it was quite outdated 😄
BTW, this (couldn't lock 16384 bytes of memory (secret_file_backend): Cannot allocate memory) error is kinda impossible to catch, since it's not thrown by any of the API I'm using. Also, this is happening only on Fedora 40 ATM, so they must have done something with that release.
I suggest you increase the memlock limit, that should get rid of one of the issues.

[DelicateIntegral]

idk if I should create a new issue. So adding a request here instead.

Is it possible to have sorting of rows based on a specific column values in future release?

Also search bar/button should be at top. It appears very small and at bottom only when I do ctrl+f. It would be nice to have it appear similar to the search button/bar in the Keyboard Shortcuts window.

Also it would be nice to be able to group rows (custom or by issuer etc).

[paolostivanin]

hello!
search will be completely refactored (and made useful) with the future major v5 release (#123). Grouping won't be implemented though.

[DelicateIntegral]

cool, but is the sorting feature in consideration for v5?

[paolostivanin]

it will provide fully functional search and rows reordering. Please let's not discuss further about v5 here, thanks