Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constraint of hardcoded RPC tx type #10450

Closed
emhane opened this issue Aug 22, 2024 · 6 comments
Closed

Remove constraint of hardcoded RPC tx type #10450

emhane opened this issue Aug 22, 2024 · 6 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain

Comments

@emhane
Copy link
Member

emhane commented Aug 22, 2024

Describe the feature

Remove constraint that alloy_network::Network::TransactionResponse must be type reth_rpc_types::Transaction.

This depends on new alloy release, for example extending all alloy_rpc_types_eth::SubscriptionResult implementations from default SubscriptionResult to generic over transaction SubscriptionResult<T>.

/// Blockchain primitive types, specific to network, e.g. block and transaction.
// todo: remove restriction `reth_rpc_types::Transaction`
type NetworkTypes: Network<TransactionResponse = Transaction>;

Additional context

No response

@emhane emhane added S-blocked This cannot more forward until something else changes C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Aug 22, 2024
@malik672
Copy link
Contributor

@emhane assign me

@emhane
Copy link
Member Author

emhane commented Aug 22, 2024

appreciate the enthusiasm @malik672 , but this one is blocked, so won't assign anyone until it becomes unblocked

@nkysg
Copy link
Contributor

nkysg commented Aug 30, 2024

It seems that it becomes unblocked. Maybe can assign malik672

@malik672
Copy link
Contributor

@nkysg nah, you do it

@emhane
Copy link
Member Author

emhane commented Aug 30, 2024

thanks for heads up @nkysg

@emhane emhane removed the S-blocked This cannot more forward until something else changes label Aug 30, 2024
@emhane
Copy link
Member Author

emhane commented Oct 26, 2024

closed by #9774

@emhane emhane closed this as completed Oct 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

No branches or pull requests

3 participants