Remove trait method TransactionCompat::otterscan_api_truncate_input

[emhane]

Describe the feature

Remove

reth/crates/rpc/rpc-types-compat/src/transaction/mod.rs

Lines 72 to 75 in 94d1d87

	/// Truncates the input of a transaction to only the first 4 bytes.
	// todo: remove in favour of using constructor on `TransactionResponse` or similar
	// <https://github.com/alloy-rs/alloy/issues/1315>.
	fn otterscan_api_truncate_input(tx: &mut Self::Transaction);

in favour of alloy-rs/alloy#1346

Additional context

No response

[emhane]

blocked by alloy-rs/alloy#1346

[nadtech-hub]

I would like to take on this one

[nadtech-hub]

It should be closed @emhane

[emhane]

by which pr @nadtech-hub ?

[nadtech-hub]

PR linked with issue that you had left reference to was closed. So rather removing this method it has to be refactored in some way. Do you have a suggestion? Issue need be edited as well in that case

[emhane]

I don't have any objections to alloy-rs/alloy#1354, will need @mattsse s input here

[nadtech-hub]

why do you need to truncate input. After reading otterscan docs I couldn't figure it out

[nadtech-hub]

Just a reminder that tx's input may contains arbitrary data not only fn call data