Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort reverts before comparing in witness hook #11355

Closed
Rjected opened this issue Sep 30, 2024 · 0 comments · Fixed by #11358
Closed

Sort reverts before comparing in witness hook #11355

Rjected opened this issue Sep 30, 2024 · 0 comments · Fixed by #11358
Labels
A-cli Related to the reth CLI A-execution Related to the Execution and EVM C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@Rjected
Copy link
Member

Rjected commented Sep 30, 2024

Made an issue for properly comparing BundleState in revm: bluealloy/revm#1813

But until then, we should just sort the reverts before comparison and make a note referring to the above issue.

We would sort them before comparing here:

reth/crates/engine/invalid-block-hooks/src/witness.rs

Line 217 in f9027ab

if bundle_state != output.state {

@Rjected Rjected added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-execution Related to the Execution and EVM A-cli Related to the reth CLI labels Sep 30, 2024
@Rjected Rjected mentioned this issue Sep 30, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-execution Related to the Execution and EVM C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(hooks): sort reverts in BundleState before comparison paradigmxyz/reth
1 participant
@Rjected