DFS refactor work #9648
Merged
DFS refactor work #9648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamadapc
requested review from
marcins,
mattcompiles,
devongovett,
lettertwo,
alshdavid,
Nikola-3,
MonicaOlejniczak,
JakeLane and
benjervis
JakeLane
reviewed
Apr 18, 2024
| if (command.exit != null) { | ||
| let {nodeId, context, exit} = command; | ||
| let newContext = exit(nodeId, command.context, actions); | ||
| if (typeof newContext !== 'undefined') { |
There was a problem hiding this comment.
/nit != null checks are usually preferred in the codebase from what I can tell
MonicaOlejniczak
approved these changes
Apr 18, 2024
marcins
approved these changes
Apr 18, 2024
| return context; | ||
| } | ||
|
|
||
| if (typeof visit !== 'function' && visit.exit) { |
There was a problem hiding this comment.
We assign enter to a const up on line 545 - any reason we don't do the same for exit? I'm guessing a typeof isn't a huge overhead anyway..
JakeLane
approved these changes
Apr 18, 2024
|
Do you have performance numbers for this? Where did this work come from? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need help with:
I will do clean-up around:
Missing from this diff is:
getChildrenwith a few generator/callback based options