BEEFY protocol name should change in accordance to GRANDPA protocol name

[adoerr]

The reasons outlined in Change the name of the GrandPa notifications protocol are valid for BEEFY as well.

Hence, the BEEFY notification protocol name should be changed in accordance with the GRANDPA notification protocol name.

[tomusdrw]

I'd suggest to do that ASAP and merge along with #186 so that we can restart Rococo :)

[adoerr]

We can change the protocol ID from paritytch to dot for now.

I'm hesitant to make the protocol ID configurable more or less unrestricted right now. For example, by introducing a protocol_id parameter to beefy_peers_set_config(). If the protocol_id argument gets screwed up or is a duplicate or is just wrong, some pretty bad mayhem may be the result.

If we do have an authoritative list of current, canonical protocol IDs, a concrete protocol_id argument could be checked against that list, of course. This would at least provide some safety measure.

Ideally, once we have a more generic, configurable BEEFY, the protocol_id should become part of the set of accepted (and properly restricted) configuration values.

[adoerr]

Protocol Id's for the various chains can the found in the Polkadot chainspec folder

[acatangiu]

Fixed in paritytech/substrate#10463