Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pallet-state-trie-migration to umbrella crate #6892

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Krayt78
Copy link
Contributor

@Krayt78 Krayt78 commented Dec 13, 2024

Part of #6504

@Krayt78
Copy link
Contributor Author

Krayt78 commented Dec 13, 2024

Sorry for bothering you about this @re-gius , this miight be a dumb question but :
I have this defensive! macro which is from frame_support, how can i get it to work with the umbrella crate since the macro uses frame_support inside of itself ? I have tried to add the defensive! macro to the prelude but it doesnt work since the inside of the macro calls for frame_support (https://paritytech.github.io/polkadot-sdk/master/src/frame_support/traits/misc.rs.html#67-95)

@re-gius
Copy link
Contributor

re-gius commented Jan 6, 2025

Sorry for bothering you about this @re-gius , this miight be a dumb question but : I have this defensive! macro which is from frame_support, how can i get it to work with the umbrella crate since the macro uses frame_support inside of itself ? I have tried to add the defensive! macro to the prelude but it doesnt work since the inside of the macro calls for frame_support (https://paritytech.github.io/polkadot-sdk/master/src/frame_support/traits/misc.rs.html#67-95)

Sorry for the late reply. The macro generates code containing frame_support, so there's no way to solve this for now. We should also avoid changing the macro code, since it may be called in places where the umbrella crate is not available. We could generate a copy of the defensive macro in the umbrella crate and use that here, but this may cause conflicting names somewhere in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants