Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2409] Backport #7011 #7052

Closed
wants to merge 1 commit into from
Closed

[stable2409] Backport #7011 #7052

wants to merge 1 commit into from

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #7011 into stable2409 from dmitry-markin.

See the documentation on how to use this bot.

@dmitry-markin @github-actions
sync: Send already connected peers to new subscribers (#7011)
20779d4 
Introduce `SyncEvent::InitialPeers` message sent to new subscribers to
allow them correctly tracking sync peers. This resolves a race condition
described in
#6573 (comment).

Fixes #6573.

---------

Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit b4177a9)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Jan 6, 2025
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jan 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@dmitry-markin
Copy link
Contributor

Closing. We don't need this in stable2409 as the issue doesn't manifest there due to present NetworkStarter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dmitry-markin