-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Combine server, admin and embed into a single repo #6
Comments
@supermacro Let me know ur thoughts on this, not something really necessary but just a nice to have. |
My main concern is around automated deployments. What do CD setups look like when you have different "things" that need to be deployed to different places and in different ways? |
In essence you have different workflows (build steps) for each deployment and then you need to pick some logic to trigger the right workflow for a code change (code push, merge or tag). The individual workflows can then be totally different and deploy using any method they need like push a docker image or send code to s3 for deployment etc. There are three main ways I have seen it done:
This is supported by github actions automatically using on:
push:
paths:
- "web/**"
branches:
- master
name: Deploy
on:
release:
types: [published]
steps:
name: deploy server
if github.event.release.tag_name == 'server.v2' # this step is only run if tag name is server
|
Ok, makes sense. I am ok with this. But not the highest priority. I think after we ship the MVP we can dedicate time to migrating things to a monorepo. |
Related issue: parlez-vous/embed#33 |
My first experience is working with three different repos is very cumbersome, I think combining them into a single mono repo maybe a good thing long term.
It would definitely simplify making cross-cutting changes and testing all three components locally (both manual and automated).
Mono repo style projects are common in the javascript world and popular tools to make them are yarn workspaces or the upcoming npm workspaces
Pros:
Cons:
The text was updated successfully, but these errors were encountered: