Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #1217

Open
4 tasks done
mtrezza opened this issue Aug 18, 2024 · 2 comments · May be fixed by #1218
Open
4 tasks done

Fix failing tests #1217

mtrezza opened this issue Aug 18, 2024 · 2 comments · May be fixed by #1218
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:ci CI related issue

Comments

@mtrezza
Copy link
Member

mtrezza commented Aug 18, 2024 •
edited
Loading

New Issue Checklist

Issue Description

At some point, tests did not run anymore because they were not identified. The CI job itself passed, but it could have been noticed by a sudden decrease in test coverage of 0%. Issue was fixed in #1216, however this also means the CI is not failing due to 9 failing tests.

Steps to reproduce

See https://github.com/parse-community/Parse-SDK-Android/actions/runs/10436358169/job/28901326229 for the failing tests, or for better overview fdd9488 which shows the 9 tests.

Actual Outcome

Tests fail, apparently due to the way the testing is conducted, not because the SDK code itself is faulty. Hence this issue is only labelled as ci. If it turns out that there are actual issues in SDK code, this will be labelled as bug.

Expected Outcome

Tests should pass.
@parse-github-assistant Parse GitHub Assistant
Copy link

parse-github-assistant bot commented Aug 18, 2024 •
edited
Loading

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added type:ci CI related issue bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) labels Aug 18, 2024
@mtrezza mtrezza mentioned this issue Aug 18, 2024
Merged
2 tasks
@mtrezza mtrezza pinned this issue Aug 18, 2024
@mtrezza
Copy link
Member Author

mtrezza commented Aug 18, 2024 •
edited
Loading

@abubkr-hago would you want to give this a try? Then we can merge your other PRs with more confidence since we know the testing is properly working.

@abubkr-hago abubkr-hago linked a pull request Aug 18, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty:$20 Bounty applies for fixing this issue (Parse Bounty Program) type:ci CI related issue
Projects
None yet
Milestone
No milestone
1 participant
@mtrezza