Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NSSecureCoding to PFFileObject #1736

Open
dhoerl opened this issue Aug 16, 2023 · 2 comments · May be fixed by #1768
Open

Add NSSecureCoding to PFFileObject #1736

dhoerl opened this issue Aug 16, 2023 · 2 comments · May be fixed by #1768
Labels
type:feature New feature or improvement of existing feature

Comments

@dhoerl
Copy link

dhoerl commented Aug 16, 2023

New Feature / Enhancement Checklist

Current Limitation

PFFileObject does not implement NSSecureCoding.

Feature / Enhancement Description

Directly add NSSecureCoding to PFFileObject. The code to do this is less than 50 lines of code. Essentially, you have PFEncoder encode the file object first, then the NSSecureCoder just encodes the dictionary returned by PFEncoder. Creating an instance is just the inverse.

Since I have the code, I could create a Pull Request with it, if there is an understanding that it would be merged at some point.

Example Use Case

I create a PFFileObject in an app, in some class. I want to then serialize that object using NSSecureCoding. I can do this with a class extension in Objective-C, but now that the app is being converted to Swift, I will need to keep the Objective-C code around forever.

Alternatives / Workarounds

Use a class extension in Objective-C

3rd Party References

NSSecureCoding is widely used.

@parse-github-assistant
Copy link

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza
Copy link
Member

mtrezza commented Aug 17, 2023

Sure, please feel free to open a PR, we will be happy to review.

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Aug 17, 2023
@dhoerl dhoerl linked a pull request Dec 31, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants