Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow _guess_delimiter to work with a single row of data #208

Merged
merged 6 commits into from
Nov 7, 2021
Merged

Allow _guess_delimiter to work with a single row of data #208

merged 6 commits into from
Nov 7, 2021

Conversation

gogowitsch
Copy link
Member

Fix #206

jimeh
jimeh approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@jimeh jimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. I assume the added test passes right? :)

@gogowitsch
Copy link
Member Author

@jimeh Thanks for the review. Yeah, locally the tests run just fine.

Sadly, the Travis integration doesn't seem to work any longer. For this PR, it just says “Read-only mode”:
image

image

I suspect it has to do with the parsecsv organisation. Maybe you have to make me admin there?

@jimeh
Copy link
Member

jimeh commented Nov 2, 2021

@fonata I've made you an admin of the org. However, I couldn't find anything obvious myself to get travis-ci working again. The .org domain is deprecated, but on the .com there's no repos.

So I took the more extreme approach and converted the Travis-CI setup to GitHub Actions here: #209

@gogowitsch gogowitsch merged commit f2b0aec into master Nov 7, 2021
@gogowitsch gogowitsch deleted the oct-2021-rc branch November 7, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimeh jimeh jimeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto()/autoDetectionForDataString() cannot determine delimiter with a single row file
2 participants
@gogowitsch @jimeh