Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error message when value is NaN #18

Open
cjmling opened this issue Dec 3, 2021 · 2 comments
Open

Incorrect error message when value is NaN #18

cjmling opened this issue Dec 3, 2021 · 2 comments

Comments

@cjmling
Copy link

cjmling commented Dec 3, 2021 

convert(value, {
      from: 'USD',
      to: 'JPY',
      base: 'USD',
      rates: exchangeRates,
    })

when value is NaN it throw ``ratesobject does not contain eitherfrom` or `to` currency!` . Which seems unrelated.

Should not it throw error related to value is NaN instead?
@xxczaki
Copy link
Member

xxczaki commented Dec 5, 2021

Could not reproduce with v3.0.0

@nilaygit-10721
Copy link

can you assign this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cjmling @xxczaki @nilaygit-10721