trade history shows ongoing trade as completed

[jorian]

When a swap is started, the trade is immediately listed as 'Completed'. It should however show the intermediary steps of a trade.

while the actual trade shows:

[jorian]

Simplest solution in my opinion would be to show the status as Pending, and when a user clicks on it, he / she can track the status of the swap.

[particle4dev]

@jorian I think it's a little confusing here
Right now, there is no concept of swap in the app
Only concept of orders (Please read atomiclabs#615)
So there is 2 type of orders: maker order and taker order
Your swap is taker order
and it's immediately listed as 'Completed' because it's filled
but its swap is still running
Does this make sense?

[jorian]

Yes it makes sense. Though I'm not sure if this is UX-friendly, since a swap can still fail. The user might think the order is completed, while the actual swap might have failed.

So, a concept of swap might actually be helpful, just for UX.

[jorian]

In the screenshot in the README of this repo, you can see how it was done in the first version of marketmaker:

Now I understand there are some more steps involved, so this might be an issue to be implemented on the longer term.