Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Sanitize unknown enum variant name to avoid collisions. #1682

Open
RCHowell opened this issue Dec 16, 2024 · 1 comment
Open

[V1] Sanitize unknown enum variant name to avoid collisions. #1682

RCHowell opened this issue Dec 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@RCHowell
Copy link
Member

Relevant Issue/Bug

#1679

In the above PR, we've hit a naming conflict with enum "UNKNOWN" and the IS UNKNOWN predicate and truth value. This lead to us believing we should sanitize all UNKNOWN enum variants (or perhaps even make it as part of the base enum abstract class) so that we avoid any additional conflicts. Sanitization makes sense here as change to something like "OTHER" may just be kicking the can down the road.

@alancai98
Copy link
Member

Specifically for relevant for this comment -- #1679 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants