Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thread.interrupted() checks to generated Kotlin code #400

Closed
dlurton opened this issue May 4, 2021 · 1 comment
Closed

Add Thread.interrupted() checks to generated Kotlin code #400

dlurton opened this issue May 4, 2021 · 1 comment

Comments

@dlurton
Copy link
Member

dlurton commented May 4, 2021

To avoid the requirement that all rewriters in PartiQL inherit from a base that itself inherits from the PIG-generated PartiqlAst.VisitorTransform, we should emit such checks in strategic places of generated Kotlin code.

This was implicitly pointed out in a question from Almann in this comment: Thread.interrupted()
@almann in #398 (comment)_

@dlurton
Copy link
Member Author

dlurton commented May 4, 2021

Created in this repository by mistake. Replaced by partiql/partiql-ir-generator#72 (which is in the correct repository.)

@dlurton dlurton closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant