Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GROUP BY when value is MISSING #328

Closed
alancai98 opened this issue Mar 23, 2023 · 1 comment
Closed

Fix GROUP BY when value is MISSING #328

alancai98 opened this issue Mar 23, 2023 · 1 comment

Comments

@alancai98
Copy link
Member

(Related to GROUP BY test failures) Current implementation of GROUP BY has the correct behavior for the case when creating groups for a value that's NULL in one binding tuple and MISSING in another (as defined in section 11.1.1). But for the edge case of when the value is just MISSING, the group uses NULL as the tuple value rather than MISSING.

@alancai98
Copy link
Member Author

The current behavior in partiql-lang-rust is correct. That is, a group key of MISSING should coerce to NULL even when all the values are MISSING. The conformance tests that were ported from Kotlin need to be fixed for this case.

Tracking issue for spec: partiql/partiql-lang#15.
Tracking issue for conformance test fix: partiql/partiql-tests#73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant