Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise bag op RFC-0007 based on latest discussions #89

Open
alancai98 opened this issue Aug 21, 2024 · 0 comments
Open

Revise bag op RFC-0007 based on latest discussions #89

alancai98 opened this issue Aug 21, 2024 · 0 comments
Labels
bug Something isn't working spec. clarification

Comments

@alancai98
Copy link
Member

alancai98 commented Aug 21, 2024

From some recent discussions and changes to the reference implementation + conformance tests, we should revise the bag operator RFC. Relevant PRs / issues:

Specifically, the following things may need changed and/or clarified:

  1. Coercion behavior in permissive vs strict mode (RFC-0007 Bag Operator Coercion Behavior Inconsistencies #76). Decided we want to error in strict mode when a SQL set op or PartiQL bag op is not a collection; apply coercion function in permissive mode.
  2. Coercion of null and missing argument to PartiQL bag op in permissive mode should apply coercion function defined in PartiQL spec related to FROM source coercion. We should coerce null or missing argument to a singleton bag in permissive mode rather than an empty bag.
  3. Allow LIMIT,OFFSET, and ORDER BY clauses to apply to SQL set ops and PartiQL bag ops.
  4. Clarify treatment of null and missing by providing an example. RFC-0007 states

For all operators, member equality is consistent with the GROUP BY clause.

Would be helpful to clarify if the resultant value of the bag op will also coerce missing to null as we currently do for GROUP BY.

@alancai98 alancai98 added bug Something isn't working spec. clarification labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spec. clarification
Projects
None yet
Development

No branches or pull requests

1 participant