Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Github contributions stamp failed #1709

Closed
jesuloluwao opened this issue Sep 22, 2023 · 1 comment · May be fixed by #1715
Closed

[BUG] Github contributions stamp failed #1709

jesuloluwao opened this issue Sep 22, 2023 · 1 comment · May be fixed by #1715
Assignees
Labels

Comments

@jesuloluwao
Copy link

Github's verification for contributions failed. He has the Contributions on at least 60 distinct days.

Github: https://github.com/LuisMurcia

Wallet: 0xc4735b87dFb6c7cC3651677651E4bF139B27Cc59

Link: Conversation with [email protected]

Customer: [email protected]
Customer ID: 814b5246-e1d6-45c8-bc18-fca491ae9d2b


Intercom Operator will send a note to this conversation when this issue is closed.

@erichfi erichfi moved this to Prioritized in Passport Sep 22, 2023
@tim-schultz tim-schultz self-assigned this Sep 25, 2023
@tim-schultz tim-schultz moved this from Prioritized to In Progress (WIP) in Passport Sep 25, 2023
@tim-schultz
Copy link
Collaborator

@erichfi for this bug we are only searching the github API three years in the past from the current date to avoid github's rate limit. A large amount of this user's contribution history is from 2019 making so it so that we do not find his older contributions and do not issue them a stamp. I put together this #1715 which would search 5 years back.

The github rate limit is 5000 points per her and each of our requests burn 1 point. So this would bring the number of possible github verifications per user down from a maximum of 1666 to 1000. 1000 still seems like a reasonable amount of github verifications per hour, but don't want to fix one problem to cause another. We could also add messaging that explains that we are only able to search through the user's x amount of years github data due to rate limiting. Thanks!

@tim-schultz tim-schultz moved this from In Progress (WIP) to Product/UX Review in Passport Sep 25, 2023
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Sep 29, 2023
@erichfi erichfi closed this as completed Sep 29, 2023
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants