Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Build Step to Ensure On-Chain Bitmap and Configured Stamps Synchronization #1730

Closed
nutrina opened this issue Oct 2, 2023 · 1 comment · May be fixed by #1860
Closed

Automated Build Step to Ensure On-Chain Bitmap and Configured Stamps Synchronization #1730

nutrina opened this issue Oct 2, 2023 · 1 comment · May be fixed by #1860
Assignees

Comments

@nutrina
Copy link
Collaborator

nutrina commented Oct 2, 2023

User Story:

As a DevOps Engineer/Developer,
I want an automated build step in the deployment pipeline that verifies synchronization between the on-chain bitmap and the configured stamps in the Passport App,
So that I can ensure data integrity and reduce manual errors.

Acceptance Criteria

GIVEN the deployment pipeline is initiated
WHEN the new build step is reached
THEN the step should check for discrepancies between the on-chain bitmap and the configured stamps in the Passport App.
AND
GIVEN a discrepancy is found
WHEN the build step runs
THEN the build should fail, and a descriptive error message should be shown.

Product & Design Links:

Tech Details:

  • Implement a script or API call to fetch the current on-chain bitmap.
  • Fetch or read the current configured stamps from the Passport App.
  • Compare both data sets to ensure they are in sync.

Open Questions:

  • Is there a preferred programming language for implementing this check?
  • Should notifications be sent to a specific channel when the build fails?

Notes/Assumptions:

  • Assumes that access to both the on-chain data and configured stamps is readily available.
  • Assumes that the build process is well-documented to assist in implementation.
@nutrina nutrina added this to Passport Oct 2, 2023
@nutrina nutrina converted this from a draft issue Oct 2, 2023
@erichfi erichfi changed the title Add build step that fails build if on-chain bitmap is out of sync with configured claimable stamps Automated Build Step to Ensure On-Chain Bitmap and Configured Stamps Synchronization Oct 2, 2023
@Jkd-eth Jkd-eth added this to the On-Chain Passport milestone Oct 11, 2023
@nutrina nutrina moved this from Prioritized to In Progress (WIP) in Passport Nov 3, 2023
@nutrina nutrina self-assigned this Nov 3, 2023
@nutrina nutrina moved this from In Progress (WIP) to Blocked in Passport Nov 8, 2023
@nutrina nutrina moved this from Blocked to In Progress (WIP) in Passport Nov 8, 2023
@nutrina
Copy link
Collaborator Author

nutrina commented Nov 8, 2023

Closing this, because as it turns out in our discussion, we want to manage the state of the bitmap on-chain.
This is why validating the current json does not make sense, we should validate the current on-chain state once that is available.
Closing this ticket and creating a follow-up: #1868

@nutrina nutrina moved this from In Progress (WIP) to Product/UX Review in Passport Nov 8, 2023
@erichfi erichfi closed this as completed Nov 13, 2023
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Nov 13, 2023
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants