Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDena Verification Bug #2000

Open
tim-schultz opened this issue Dec 21, 2023 · 2 comments · May be fixed by #2001
Open

IDena Verification Bug #2000

tim-schultz opened this issue Dec 21, 2023 · 2 comments · May be fixed by #2001
Assignees
@tim-schultz

Comments

@tim-schultz
Copy link
Collaborator

A decent number of unhandled errors are being thrown from the Idena signin process.

Here is a sample of the errors being thrown when you do not qualify for a stamp.

{
		"code": 403,
		"error": "There was an unexpected error during verification. TypeError: Cannot read properties of undefined (reading 'state') at /usr/src/platforms/dist/commonjs/Idena/procedures/idenaSignIn.js:77:56"
	},
	{
		"code": 403,
		"error": "There was an unexpected error during verification. TypeError: Cannot read properties of undefined (reading 'state') at /usr/src/platforms/dist/commonjs/Idena/procedures/idenaSignIn.js:77:56"
	},
	{
		"code": 403,
		"error": "There was an unexpected error during verification. TypeError: Cannot read properties of undefined (reading 'state') at /usr/src/platforms/dist/commonjs/Idena/procedures/idenaSignIn.js:77:56"
	},

The linked PR should resolve this.
@tim-schultz tim-schultz self-assigned this Dec 21, 2023
@tim-schultz tim-schultz converted this from a draft issue Dec 21, 2023
@tim-schultz tim-schultz linked a pull request Dec 21, 2023 that will close this issue
Open
@tim-schultz tim-schultz moved this from Prioritized to Blocked in Passport Dec 21, 2023
@tim-schultz
Copy link
Collaborator Author

Just waiting review

@tim-schultz
Copy link
Collaborator Author

I also manually disabled the alarm until this patch can be released. The alarm should be re-enabled on the next deployment

@erichfi erichfi moved this from Blocked to Product/UX Review in Passport Jan 8, 2024
@erichfi erichfi moved this from Product/UX Review to Ready to Deploy in Passport Jan 9, 2024
@erichfi erichfi moved this from Ready to Deploy to Done in Passport Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tim-schultz tim-schultz

Labels
None yet
Projects
Passport New
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(platforms): if state/stake is not returned, return default value passportxyz/passport
1 participant
@tim-schultz