Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide what mean the "Mean" button should display #7

Open
patrikhuber opened this issue Apr 1, 2018 · 2 comments
Open

Decide what mean the "Mean" button should display #7

patrikhuber opened this issue Apr 1, 2018 · 2 comments
Labels
enhancement
Milestone
v0.2.0

Comments

@patrikhuber
Copy link
Owner

Shall we display the identity mean, or the identity + expression mean (for models with PCA expression models)? Probably we want means to do both.
Also depends on what we decide here: patrikhuber/eos#188
@patrikhuber patrikhuber added this to the v0.2.0 milestone Apr 1, 2018
@patrikhuber
Copy link
Owner Author

0beb6a8 adds two buttons, one to display each.

@patrikhuber
Copy link
Owner Author

patrikhuber commented Apr 1, 2018 •
edited
Loading

Re-opening, this got broken by #5. The slider code now always redraws the model, including the expression mean, if a model has expressions.
I think a checkbox "Identity only" might be a good idea, or "Use expression model".

@patrikhuber patrikhuber reopened this Apr 1, 2018
@patrikhuber patrikhuber mentioned this issue Apr 1, 2018
Open
patrikhuber added a commit that referenced this issue Apr 1, 2018
@patrikhuber
Update the mesh according to slider values
f8d24de 
Working in principle but a few issues are left - see #5, #7, #9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@patrikhuber