Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide credentials from the code, use env variables instead. #457

Open
tp-cai opened this issue Sep 23, 2021 · 1 comment
Open

Hide credentials from the code, use env variables instead. #457

tp-cai opened this issue Sep 23, 2021 · 1 comment

Comments

@tp-cai
Copy link

tp-cai commented Sep 23, 2021

Just an idea and I think it would be helpful since generally, we don't want to hard code our credentials to the code. Right now I have replaced the value of DB credentials in Constant.scala which holds me back from pushing the code to the cloud.

@patsonluk
Copy link
Owner

@tp-cai sorry probably have missed this, The db credentials can be provided via config. is that good enough? https://github.com/patsonluk/airline/blob/master/airline-data/src/main/scala/com/patson/data/Constants.scala#L190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants