Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue265 airplane series - Added all the Airplane codes, pictures for V1.2 #266

Open
wants to merge 5 commits into
base: issue265-airplane-series
Choose a base branch
from

Conversation

Germanwings
Copy link
Contributor

Hey, I added all the Airplane Images that were possible and changed the code for the models. I tried to make the models fairer and even, so every model can get used. So don't be too harsh and crank the efficiency of everything too far down as you did with the a350 for example before. Then no one will use it again. I gave every plane a little pro, like a little more efficient or some more seats in the same class. Feel free to suggest and discuss changes.

Germanwings and others added 4 commits February 2, 2020 16:09
Added and expanded/changed airplanes, stats. range, speed, capacity, etc. researched from Wikipedia. I had to play around with the prices and fuel. Feel free to suggest any more adjustments.
Added all missing Airplane pictures.
@patsonluk
Copy link
Owner

Starting to go through the changes :)

Some quick questions:

  1. Wondering why did u remove the imageURL? We need that for the link to norebbo. Can you please get the links please? And restore the links on the existing model?
  2. The change should ideally show only ur changes (so the existing lines should not be changed). This is for the ease of going through the changes
  3. Also we would want to preserve the original ordering for airplanes by capacity , the reason for that is we can easily compare the parameters of airplanes of similar scale, with the new ordering now, it's pretty hard to do it

I understand it will be a lot of work for you to do point 2 and 3. Can you at least get point 1 done? I can fix the 2 and 3 later

@Germanwings
Copy link
Contributor Author

Hello, yes I can add the Image URLs back, completely forgot about them. And in terms of 2,3 I restructured that in the thought of going after the airplane families.

@patsonluk
Copy link
Owner

patsonluk commented Feb 19, 2020

hehe thanks for adding the url back!

For 2. it's quite important as we want to make sure no existing airplanes are missing or changed. I noticed that one model was missing and some of the names have been changed (Embraer EMB170-200, Embraer EMB190 etc)? The name of an airplane is quite important as it's used as a key for lookup so it will result as missing airplanes if anything is changed ")

@patsonluk
Copy link
Owner

Completely unrelated. But r you interested in becoming game admin? The ONLY duty right now is basically ban the bad apples from chat if you found any. It's super easy u can find the extra option in game screen so just a matter of finding the airline in rivals then select the option.

You will have a star next to you airline if you become the admin :)

@Germanwings
Copy link
Contributor Author

Sure, I would be more than happy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants