Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom divider styles in icons.css #4033

Closed
wise-king-sullyman opened this issue May 21, 2024 · 2 comments · Fixed by #4146
Closed

Remove custom divider styles in icons.css #4033

wise-king-sullyman opened this issue May 21, 2024 · 2 comments · Fixed by #4146
Assignees
@nicolethoen
Milestone
Penta beta release

Comments

@wise-king-sullyman
Copy link
Collaborator

Blocked by patternfly/patternfly-react#10390

When/if the above enhancement is complete we should see if we can use that new functionality to get rid of the custom styles we have for a divider in the icons stylesheet.

Followup from #4011 (comment)

CC @mcoker
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 21, 2024
@wise-king-sullyman wise-king-sullyman mentioned this issue May 21, 2024
Merged
@nicolethoen nicolethoen moved this from Needs triage to Backlog in PatternFly Issues Jun 4, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 4, 2024
@nicolethoen nicolethoen moved this from Backlog to Not started in PatternFly Issues Jul 8, 2024
@nicolethoen nicolethoen self-assigned this Jul 10, 2024
@nicolethoen
Copy link
Collaborator

Do this as a follow up to #4102

@nicolethoen nicolethoen mentioned this issue Jul 18, 2024
Merged
@nicolethoen nicolethoen linked a pull request Jul 18, 2024 that will close this issue
fix: update icons css and remove unused images #4146
Merged
@nicolethoen
Copy link
Collaborator

Closed by #4146

@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
None yet
Projects
PatternFly Issues
Archived in project
PatternFly Extensions
Status: Needs triage
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix: update icons css and remove unused images nicolethoen/patternfly-org
2 participants
@wise-king-sullyman @nicolethoen