From 87f5f244b3506ba53244b4f0456783a11aaec8d8 Mon Sep 17 00:00:00 2001
From: Austin Sullivan <ausulliv@redhat.com>
Date: Mon, 24 Jul 2023 09:41:49 -0400
Subject: [PATCH] fix(Toolbar): applied chip container class only if it's not
 hidden (#9398)

---
 .../src/components/Toolbar/ToolbarChipGroupContent.tsx      | 6 ++++--
 .../__snapshots__/ToolbarChipGroupContent.test.tsx.snap     | 2 +-
 .../Toolbar/__tests__/__snapshots__/Toolbar.test.tsx.snap   | 4 ++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/packages/react-core/src/components/Toolbar/ToolbarChipGroupContent.tsx b/packages/react-core/src/components/Toolbar/ToolbarChipGroupContent.tsx
index 1e3448bacda..4a0e3fa7a2c 100644
--- a/packages/react-core/src/components/Toolbar/ToolbarChipGroupContent.tsx
+++ b/packages/react-core/src/components/Toolbar/ToolbarChipGroupContent.tsx
@@ -68,12 +68,14 @@ export class ToolbarChipGroupContent extends React.Component<ToolbarChipGroupCon
         (canUseDOM ? window.innerWidth : 1200) < globalBreakpoints[collapseListedFiltersBreakpoint];
     }
 
+    const isHidden = numberOfFilters === 0 || isExpanded;
+
     return (
       <div
         className={css(
           styles.toolbarContent,
-          !collapseListedFilters && styles.modifiers.chipContainer,
-          (numberOfFilters === 0 || isExpanded) && styles.modifiers.hidden,
+          !isHidden && !collapseListedFilters && styles.modifiers.chipContainer,
+          isHidden && styles.modifiers.hidden,
           className
         )}
         {...((numberOfFilters === 0 || isExpanded) && { hidden: true })}
diff --git a/packages/react-core/src/components/Toolbar/__tests__/Generated/__snapshots__/ToolbarChipGroupContent.test.tsx.snap b/packages/react-core/src/components/Toolbar/__tests__/Generated/__snapshots__/ToolbarChipGroupContent.test.tsx.snap
index 7e27658c62a..8135d2d9540 100644
--- a/packages/react-core/src/components/Toolbar/__tests__/Generated/__snapshots__/ToolbarChipGroupContent.test.tsx.snap
+++ b/packages/react-core/src/components/Toolbar/__tests__/Generated/__snapshots__/ToolbarChipGroupContent.test.tsx.snap
@@ -3,7 +3,7 @@
 exports[`ToolbarChipGroupContent should match snapshot (auto-generated) 1`] = `
 <DocumentFragment>
   <div
-    class="pf-v5-c-toolbar__content pf-m-chip-container pf-m-hidden string"
+    class="pf-v5-c-toolbar__content pf-m-hidden string"
     hidden=""
   >
     <div
diff --git a/packages/react-core/src/components/Toolbar/__tests__/__snapshots__/Toolbar.test.tsx.snap b/packages/react-core/src/components/Toolbar/__tests__/__snapshots__/Toolbar.test.tsx.snap
index ed402cfa123..31e809b78b6 100644
--- a/packages/react-core/src/components/Toolbar/__tests__/__snapshots__/Toolbar.test.tsx.snap
+++ b/packages/react-core/src/components/Toolbar/__tests__/__snapshots__/Toolbar.test.tsx.snap
@@ -44,7 +44,7 @@ exports[`Toolbar should render inset 1`] = `
       </div>
     </div>
     <div
-      class="pf-v5-c-toolbar__content pf-m-chip-container pf-m-hidden"
+      class="pf-v5-c-toolbar__content pf-m-hidden"
       hidden=""
     >
       <div
@@ -395,7 +395,7 @@ exports[`Toolbar should render with page inset flag 1`] = `
       </div>
     </div>
     <div
-      class="pf-v5-c-toolbar__content pf-m-chip-container pf-m-hidden"
+      class="pf-v5-c-toolbar__content pf-m-hidden"
       hidden=""
     >
       <div