diff --git a/packages/react-core/src/components/HelperText/HelperTextItem.tsx b/packages/react-core/src/components/HelperText/HelperTextItem.tsx index 25812cc9ee1..0cb1a870581 100644 --- a/packages/react-core/src/components/HelperText/HelperTextItem.tsx +++ b/packages/react-core/src/components/HelperText/HelperTextItem.tsx @@ -38,7 +38,6 @@ export interface HelperTextItemProps extends React.HTMLProps, indeterminate: , warning: , success: , @@ -57,15 +56,16 @@ export const HelperTextItem: React.FunctionComponent = ({ }: HelperTextItemProps) => { const Component = component as any; const isNotDefaultVariant = variant !== 'default'; + const defaultIcon = isNotDefaultVariant && defaultVariantIcons[variant]; return ( - {(isNotDefaultVariant || icon) && ( + {(defaultIcon || icon) && ( - {icon || defaultVariantIcons[variant]} + {icon || defaultIcon} )} diff --git a/packages/react-core/src/components/HelperText/examples/HelperText.md b/packages/react-core/src/components/HelperText/examples/HelperText.md index 4c73fe3a04c..c9805fae7d6 100644 --- a/packages/react-core/src/components/HelperText/examples/HelperText.md +++ b/packages/react-core/src/components/HelperText/examples/HelperText.md @@ -15,13 +15,13 @@ import ExclamationIcon from '@patternfly/react-icons/dist/esm/icons/exclamation- ### Basic -```ts file="HelperTextStatic.tsx" +```ts file="HelperTextBasic.tsx" ``` ### With custom icons -```ts file="HelperTextStaticWithCustomIcon.tsx" +```ts file="HelperTextWithCustomIcon.tsx" ``` @@ -29,6 +29,6 @@ import ExclamationIcon from '@patternfly/react-icons/dist/esm/icons/exclamation- You can pass multiple `` components inside a single `` container. -```ts file="HelperTextMultipleStatic.tsx" +```ts file="HelperTextMultipleItems.tsx" ```