Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use plain, no-padding button on form help icon #10055

Closed
2 tasks
srambach opened this issue Jan 31, 2024 · 3 comments · Fixed by #10016
Closed
2 tasks

Use plain, no-padding button on form help icon #10055

srambach opened this issue Jan 31, 2024 · 3 comments · Fixed by #10016
Assignees
@thatblindgeye
Milestone
Penta alpha release

Comments

@srambach
Copy link
Member

There are various demos and examples that use a button for the help icon on the form label - these should be changed to a plain, no padding button.

Known spots:

  • Form examples
  • Password strength examples
@tlabaj
Copy link
Contributor

tlabaj commented Feb 2, 2024

Is this for v5 or v6 @srambach

@srambach
Copy link
Member Author

srambach commented Feb 8, 2024

V6!

@tlabaj tlabaj added the PF6 label Feb 8, 2024
@tlabaj tlabaj assigned tlabaj and thatblindgeye and unassigned tlabaj Feb 8, 2024
@thatblindgeye thatblindgeye mentioned this issue Feb 8, 2024
Merged
@thatblindgeye thatblindgeye linked a pull request Feb 8, 2024 that will close this issue
Consume core Penta updates: Form controls, checkbox, radio #10016
Merged
@thatblindgeye
Copy link
Contributor

Closed by #10016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatblindgeye thatblindgeye

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta alpha release
Development

Successfully merging a pull request may close this issue.

Consume core Penta updates: Form controls, checkbox, radio adamviktora/patternfly-react
3 participants
@srambach @tlabaj @thatblindgeye