Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [Modal] - [TypeScript typing is wrong] #10361

Closed
jelly opened this issue May 14, 2024 · 0 comments · Fixed by #10474
Closed

Bug - [Modal] - [TypeScript typing is wrong] #10361

jelly opened this issue May 14, 2024 · 0 comments · Fixed by #10474
Assignees

Comments

@jelly
Copy link
Contributor

jelly commented May 14, 2024

Describe the problem

Modal

How do you reproduce the problem?

The TypeScript type for a Modal's title is a string while passing a React component, so now that we converted part of our code to TypeScript the type check complains:

<Modal
    title={<>this is some <b>text</b></>}

The title ends up being passed from Modal to ModelContent to ModalBoxTitle which does accept a React.ReactNode.

  /** Content rendered inside the modal box title. */
  title: React.ReactNode;

Expected behavior

No typing error

Is this issue blocking you?

No

What is your product and what release date are you targeting?

Cockpit

Any other information?

@jelly jelly added the bug label May 14, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 14, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues May 20, 2024
@tlabaj tlabaj added this to the Prioritized Backlog milestone May 20, 2024
@adamviktora adamviktora self-assigned this May 29, 2024
@adamviktora adamviktora moved this from Backlog to Not started in PatternFly Issues May 29, 2024
@adamviktora adamviktora moved this from Not started to In Progress in PatternFly Issues May 29, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Jun 3, 2024
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants