Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates - select improvements #10409

Closed
4 tasks
kmcfaul opened this issue May 21, 2024 · 1 comment · Fixed by #10473
Closed
4 tasks

Templates - select improvements #10409

kmcfaul opened this issue May 21, 2024 · 1 comment · Fixed by #10473
Assignees

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented May 21, 2024

  • add toggleProps that spreads to the toggle (allowing customization of toggle width and other MenuToggle properties)
  • add informational isMenuOpen callback about open state, returning the current menu state - this can be tracked by keeping a local isOpen boolean that flips when onToggle is called, updated when onToggle is called internally
  • add id prop / add generated default ID rather than static - this can already be passed by spread props, removed the default ids
  • add spreadable props to other inner components to aid in customization (later going back to expose specific props in the API if we find one always being used)
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 21, 2024
@kmcfaul kmcfaul moved this from Needs triage to Not started in PatternFly Issues May 21, 2024
@kmcfaul kmcfaul self-assigned this May 22, 2024
@kmcfaul
Copy link
Contributor Author

kmcfaul commented May 22, 2024

Keep in mind if these improvements can also be applied to the Dropdown template

@kmcfaul kmcfaul moved this from Not started to In Progress in PatternFly Issues May 23, 2024
@kmcfaul kmcfaul moved this from In Progress to PR Review in PatternFly Issues May 29, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant