Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - eslint-plugin-patternfly-react - micromatch vulnerability #10475

Closed
dlabrecq opened this issue May 29, 2024 · 1 comment
Closed

Bug - eslint-plugin-patternfly-react - micromatch vulnerability #10475

dlabrecq opened this issue May 29, 2024 · 1 comment

Comments

@dlabrecq
Copy link
Member

dlabrecq commented May 29, 2024

Cost Management inherits micromatch from eslint-plugin-patternfly-react, which has the vulnerability described below.

Red Hat requires a by 12-Aug-2024
See https://issues.redhat.com/browse/COST-5041

Flaw:

CVE-2024-4067 micromatch: vulnerable to Regular Expression Denial of Service
https://bugzilla.redhat.com/show_bug.cgi?id=2280601

The NPM package micromatch is vulnerable to Regular Expression Denial of Service (ReDoS). The vulnerability occurs in micromatch.braces() in index.js because the pattern .* will greedily match anything. By passing a malicious payload, the pattern matching will keep backtracking to the input while it doesn't find the closing bracket. As the input size increases, the consumption time will also increase until it causes the application to hang or slow down. There was a merged fix but further testing shows the issue persists. This issue should be mitigated by using a safe pattern that won't start backtracking the regular expression due to greedy matching.

https://devhub.checkmarx.com/cve-details/CVE-2024-4067/
https://github.com/micromatch/micromatch/blob/2c56a8604b68c1099e7bc0f807ce0865a339747a/index.js#L448
micromatch/micromatch#243
micromatch/micromatch#247

Output from npm why micromatch
micromatch

@dlabrecq dlabrecq added the bug label May 29, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 29, 2024
@dlabrecq dlabrecq changed the title Bug - eslint-plugin-patternfly-react - vulnerability Bug - eslint-plugin-patternfly-react - vulnerability 1 of 2 May 29, 2024
@dlabrecq dlabrecq changed the title Bug - eslint-plugin-patternfly-react - vulnerability 1 of 2 Bug - eslint-plugin-patternfly-react - micromatch vulnerability May 29, 2024
@dlabrecq
Copy link
Member Author

Closing as this is not a production issue for Cost Management

@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant