Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React-icons - update README reference of v5 to v6 #10480

Closed
mcoker opened this issue May 29, 2024 · 1 comment · Fixed by #10575
Closed

React-icons - update README reference of v5 to v6 #10480

mcoker opened this issue May 29, 2024 · 1 comment · Fixed by #10575
Assignees
@evwilkin
Milestone
Penta final release

Comments

@mcoker
Copy link
Contributor

mcoker commented May 29, 2024

Small thing I noticed in the README, the reference to .pf-v5-svg should update to .pf-v6-svg

patternfly-react/packages/react-icons/README.md

Line 17 in 2b5a598

All icons from @patternfly/react-icons have the HTML class pf-v5-svg applied and CSS styles applied via @patternfly/react-styles.

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 29, 2024
@nicolethoen nicolethoen added this to the Penta beta release milestone Jun 3, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jun 4, 2024
@evwilkin evwilkin self-assigned this Jun 7, 2024
@evwilkin evwilkin moved this from On deck to PR Review in PatternFly Issues Jun 7, 2024
@evwilkin evwilkin mentioned this issue Jun 10, 2024
Merged
@evwilkin evwilkin linked a pull request Jun 10, 2024 that will close this issue
fix(docs): fix v6 classname in icons readme #10575
Merged
@evwilkin
Copy link
Member

evwilkin commented Jul 1, 2024

Closed by #10575

@evwilkin evwilkin closed this as completed Jul 1, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evwilkin evwilkin

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
Development

Successfully merging a pull request may close this issue.

fix(docs): fix v6 classname in icons readme evwilkin/patternfly-react
3 participants
@evwilkin @nicolethoen @mcoker