Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint - add hasNoOffset support to actions #10485

Closed
mcoker opened this issue May 30, 2024 · 1 comment · Fixed by #10488
Closed

Hint - add hasNoOffset support to actions #10485

mcoker opened this issue May 30, 2024 · 1 comment · Fixed by #10488
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented May 30, 2024

In patternfly/patternfly#6708, we added .pf-m-no-offset to .pf-v6-c-hint__actions, so we'll need support for that in the react <Hint>. This basically matches the same feature for <Card> actions, so maybe the API can be the same?

/** Flag indicating that the actions have no offset */
hasNoOffset?: boolean;

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 30, 2024
@evwilkin evwilkin self-assigned this May 30, 2024
@evwilkin evwilkin moved this from Needs triage to PR Review in PatternFly Issues May 31, 2024
@evwilkin evwilkin linked a pull request May 31, 2024 that will close this issue
@evwilkin evwilkin added this to the Penta beta release milestone May 31, 2024
@evwilkin
Copy link
Member

evwilkin commented Jun 6, 2024

Closed by #10488

@evwilkin evwilkin closed this as completed Jun 6, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants