Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverse PF Logo showing on multiple react demo examples #10576

Closed
lboehling opened this issue Jun 10, 2024 · 2 comments · Fixed by patternfly/patternfly-org#4194
Closed

Inverse PF Logo showing on multiple react demo examples #10576

lboehling opened this issue Jun 10, 2024 · 2 comments · Fixed by patternfly/patternfly-org#4194
Assignees
@rebeccaalpert
Labels
Documentation 📝
Milestone
Penta final release

Comments

@lboehling
Copy link
Collaborator

lboehling commented Jun 10, 2024 •
edited
Loading

There are multiple full page demos where the PF logo is showing in inverse on light theme

so far we've seen this on

  • banner react demos
  • wizard demos
  • jumplinks demos
  • data list demos
  • nav demos
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jun 10, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Jun 13, 2024

Let's make sure all demos have the correct logo.

@tlabaj tlabaj moved this from Needs triage to Ready to assign in PatternFly Issues Jun 13, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Jun 13, 2024
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Aug 14, 2024
@rebeccaalpert rebeccaalpert moved this from Not started to In Progress in PatternFly Issues Aug 14, 2024
rebeccaalpert added a commit to rebeccaalpert/patternfly-org that referenced this issue Aug 15, 2024
@rebeccaalpert
fix(docs): update screenshots
481750c 
Should hopefully fix patternfly/patternfly-react#10576 once it's moved to the staging site.
@rebeccaalpert rebeccaalpert mentioned this issue Aug 15, 2024
Merged
@rebeccaalpert rebeccaalpert moved this from In Progress to PR Review in PatternFly Issues Aug 16, 2024
@rebeccaalpert rebeccaalpert linked a pull request Aug 16, 2024 that will close this issue
fix(docs): update screenshots patternfly/patternfly-org#4194
Merged
nicolethoen pushed a commit to patternfly/patternfly-org that referenced this issue Aug 21, 2024
@rebeccaalpert
fix(docs): update screenshots (#4194)
782fc58 
* fix(docs): update screenshots

Should hopefully fix patternfly/patternfly-react#10576 once it's moved to the staging site.

* Run screenshots with Chromium Version 128.0.6613.0

* Bump to latest React version

Fixes patternfly-docs/generated/components/back-to-top/react-demos/using-name-selector.png
@rebeccaalpert
Copy link
Member

This should be all set on https://staging-v6.patternfly.org now!

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebeccaalpert rebeccaalpert

Labels
Documentation 📝
Projects
PatternFly Issues
Archived in project
Milestone
Penta final release
Development

Successfully merging a pull request may close this issue.

fix(docs): update screenshots rebeccaalpert/patternfly-org
4 participants
@rebeccaalpert @mcoker @tlabaj @lboehling