Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion - spread props in sub components #10678

Closed
nicolethoen opened this issue Jun 28, 2024 · 1 comment · Fixed by #10679
Closed

Accordion - spread props in sub components #10678

nicolethoen opened this issue Jun 28, 2024 · 1 comment · Fixed by #10679
Assignees
@nicolethoen
Milestone
Penta beta release

Comments

@nicolethoen
Copy link
Contributor

AccordionItem and AccordionExpandableContentBody don't spread props.

Fixing this will able us to remove many custom styles from org (primarily related to this issue)
@nicolethoen nicolethoen self-assigned this Jun 28, 2024
@nicolethoen nicolethoen mentioned this issue Jun 28, 2024
Merged
@nicolethoen nicolethoen linked a pull request Jul 1, 2024 that will close this issue
fix: accordion sub components spread props #10679
Merged
@nicolethoen nicolethoen added this to the Penta beta release milestone Jul 10, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Jul 18, 2024

closed by #10679

@tlabaj tlabaj closed this as completed Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolethoen nicolethoen

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
Penta beta release
Development

Successfully merging a pull request may close this issue.

fix: accordion sub components spread props nicolethoen/patternfly-react
2 participants
@nicolethoen @tlabaj