Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page - support for the main content area to fill the viewport height #10747

Closed
mcoker opened this issue Jul 15, 2024 · 0 comments · Fixed by #10760
Closed

Page - support for the main content area to fill the viewport height #10747

mcoker opened this issue Jul 15, 2024 · 0 comments · Fixed by #10760
Assignees

Comments

@mcoker
Copy link
Contributor

mcoker commented Jul 15, 2024

follow up to core PR patternfly/patternfly#6832

  • Add support for .pf-m-fill on .pf-v6-c-page__main-container. Probably fine for this to have a generic prop like <Page isContentFill> or isMainContentFill or something like that?
    • The reason for this is the main content area (and page sections) no longer grow to fill the viewport height by default. If a user has a layout where they want a page section to fill the available space (or they just want the white box around the content area to extend to the bottom of the viewport), they'll need to set .pf-m-fill on __main-container and on any page sections they want to fill.
  • Verify we support .pf-m-fill and .pf-m-no-fill on these classes and add support if we don't
    • .pf-v6-c-page__main-section
    • .pf-v6-c-page__main-group
    • .pf-v6-c-page__main-wizard
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 15, 2024
@tlabaj tlabaj moved this from Needs triage to On deck in PatternFly Issues Jul 16, 2024
@tlabaj tlabaj added this to the Penta beta release milestone Jul 16, 2024
@kmcfaul kmcfaul moved this from On deck to Not started in PatternFly Issues Jul 16, 2024
@kmcfaul kmcfaul self-assigned this Jul 16, 2024
@kmcfaul kmcfaul linked a pull request Jul 17, 2024 that will close this issue
@kmcfaul kmcfaul moved this from Not started to PR Review in PatternFly Issues Jul 17, 2024
@kmcfaul kmcfaul closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants