Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuToggle - icons should be passed via icon prop #10841

Open
kmcfaul opened this issue Aug 7, 2024 · 0 comments · May be fixed by #11005
Open

MenuToggle - icons should be passed via icon prop #10841

kmcfaul opened this issue Aug 7, 2024 · 0 comments · May be fixed by #11005
Assignees
@evwilkin
Milestone
2024.Q3

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 7, 2024

Our examples/demos should be reviewed to make sure we are passing icons in menu toggles in through the icon prop so they are wrapped in the correct icon wrapper.
@tlabaj tlabaj added the Post v6 label Aug 27, 2024
@kmcfaul kmcfaul added this to the Penta final release milestone Aug 27, 2024
@kmcfaul kmcfaul removed the Post v6 label Aug 27, 2024
@evwilkin evwilkin linked a pull request Sep 15, 2024 that will close this issue
Open
@evwilkin evwilkin self-assigned this Sep 15, 2024
@kmcfaul kmcfaul modified the milestones: Penta final release, 2024.Q3 Sep 26, 2024
@kmcfaul kmcfaul removed the Tech debt label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evwilkin evwilkin

Labels
None yet
Projects
PatternFly Issues
Status: PR Review
Milestone
2024.Q3
Development

Successfully merging a pull request may close this issue.

chore(docs): update menutoggle examples icon prop evwilkin/patternfly-react
3 participants
@evwilkin @tlabaj @kmcfaul