Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput/TextinputGroup - consistent status/validation prop naming #10851

Open
thatblindgeye opened this issue Aug 12, 2024 · 0 comments
Open
Labels
Breaking change 💥 this change requires a major release and has API changes.

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
Related to convo chain at #10815 (comment)

Would also pertain to other components that have a status/validation type prop. We should align on:

  • whether the prop should be status or validation (personally would lean towards status)
  • whether the prop type should only include valid class values, e.g. success, error/danger (another thing to align on), warning, info, and custom, or whether there should also be a "default" value to sort of unset it. If the latter, then does "default" make sense or should it be "none" or something else?

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Aug 12, 2024
@tlabaj tlabaj added Breaking change 💥 this change requires a major release and has API changes. Post v6 labels Aug 27, 2024
@tlabaj tlabaj added this to the Breaking Changes milestone Sep 5, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking change 💥 this change requires a major release and has API changes.
Projects
Status: Backlog
Development

No branches or pull requests

3 participants