Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [ToolbarFilter] - [chipGroupContentRef.current is null] #10857

Closed
ammont82 opened this issue Aug 14, 2024 · 3 comments · Fixed by #11223
Closed

Bug - [ToolbarFilter] - [chipGroupContentRef.current is null] #10857

ammont82 opened this issue Aug 14, 2024 · 3 comments · Fixed by #11223
Assignees
Labels
Milestone

Comments

@ammont82
Copy link

Describe the problem
Using component in other component raise chipGroupContentRef.current is null exception in some cases.

How do you reproduce the problem?
Acess to this URL: https://console.redhat.com/openshift/assisted-installer/clusters and wait for a while. The error appears after some time.

Expected behavior
Not error shown in the page.

Is this issue blocking you?
Yes, I implement it a workaround to solve it: https://github.com/openshift-assisted/assisted-installer-ui/pull/2652/files#diff-9e34dbbb99bb6a4515f6f35e3ba200ac0d376f46e53f13f00ae66f777d1bd229 creating a CustomToolbarFilter component.

To solve this issue, if you go to https://github.com/patternfly/patternfly-react/blob/main/packages/react-core/src/components/Toolbar/ToolbarFilter.tsx#L137
and add this piece of code, it works:

  {chipGroupContentRef &&
            chipGroupContentRef.current !== null &&
            chipGroupContentRef.current.firstElementChild !== null &&
            ReactDOM.createPortal(chipGroup, chipGroupContentRef.current.firstElementChild)}

Screenshots
image

What is your environment?

  • Browser [chrome]
  • Version [Versión 127.0.6533.99 (Build oficial) (64 bits)]

What is your product and what release date are you targeting?
I'm using patternfly/react-core 5.2.0

Any other information?

@jgyselov
Copy link

This might be a better screenshot of the error:

image

@tlabaj tlabaj added this to the 2024.Q4 milestone Aug 22, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Aug 22, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@kmcfaul kmcfaul removed the bug label Oct 25, 2024
@github-actions github-actions bot removed the wontfix label Oct 28, 2024
@tlabaj tlabaj added the PF5 label Nov 5, 2024
@tlabaj tlabaj moved this from Backlog to Ready to assign in PatternFly Issues Nov 5, 2024
@tlabaj tlabaj self-assigned this Nov 18, 2024
@tlabaj tlabaj linked a pull request Nov 19, 2024 that will close this issue
@tlabaj tlabaj pinned this issue Nov 19, 2024
@tlabaj tlabaj unpinned this issue Nov 19, 2024
@tlabaj tlabaj moved this from Ready to assign to PR Review in PatternFly Issues Nov 19, 2024
@tlabaj
Copy link
Contributor

tlabaj commented Nov 20, 2024

closed by #11223

@tlabaj tlabaj closed this as completed Nov 20, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Nov 20, 2024
@tlabaj tlabaj reopened this Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Nov 20, 2024
@tlabaj tlabaj closed this as completed Nov 20, 2024
@tlabaj tlabaj reopened this Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Nov 20, 2024
@tlabaj tlabaj closed this as completed Nov 20, 2024
@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants