Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateTokens script should prfeix tokens with t #10985

Closed
tlabaj opened this issue Sep 12, 2024 · 0 comments · Fixed by #11002
Closed

generateTokens script should prfeix tokens with t #10985

tlabaj opened this issue Sep 12, 2024 · 0 comments · Fixed by #11002
Assignees

Comments

@tlabaj
Copy link
Contributor

tlabaj commented Sep 12, 2024

Please describe the issue

generateTokens script should prfeix tokens with t

From slack thread

WARNING in ./node_modules/@patternfly/react-tokens/dist/esm/chart_global_Fill_Color_white.js
There are multiple modules with names that only differ in casing.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Use equal casing. Compare these module identifiers:

  • /Users/talton/github/ansible/aap-ui/node_modules/@patternfly/react-tokens/dist/esm/chart_global_Fill_Color_white.js
    Used by 1 module(s), i. e.
    /Users/talton/github/ansible/aap-ui/node_modules/@patternfly/react-tokens/dist/esm/index.js
  • /Users/talton/github/ansible/aap-ui/node_modules/@patternfly/react-tokens/dist/esm/chart_global_fill_color_white.js
    Used by 1 module(s), i. e.
    /Users/talton/github/ansible/aap-ui/node_modules/@patternfly/react-tokens/dist/esm/index.js

1:50
WARNING in ./node_modules/@patternfly/react-tokens/dist/esm/index.js 4803:0-72
export 'chart_global_label_margin' (reexported as 'chart_global_label_margin') was not found in './chart_global_label_margin' (possible exports: chart_global_label_Margin, default)
1:54
Both of those were tokens errors for tokens that we are not using, but are part of the PF libs.

Dan
Yesterday at 2:21 PM
Looks like the react-tokens/dist/esm/index.d.ts file contains both exports below
export { chart_global_label_Margin } from './chart_global_label_Margin';
export { chart_global_label_margin } from './chart_global_label_margin';
The filename is chart_global_label_margin, while chart_global_label_Margin is the default export
The index.d.ts file contains a lot of duplication like that (edited)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant