Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClipboardCopy - inline buttons missing no-padding styling #11124

Closed
thatblindgeye opened this issue Oct 22, 2024 · 2 comments
Closed

ClipboardCopy - inline buttons missing no-padding styling #11124

thatblindgeye opened this issue Oct 22, 2024 · 2 comments
Labels

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Oct 22, 2024

Describe the enhancement or change
Core v6 has the pf-m-no-padding class applied to an inline "copy" or other action button, while React does not. Assuming core is the correct design implementation, React needs to add that class. cc @mcoker for confirmation

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@thatblindgeye thatblindgeye changed the title ClipboardCopy - inline copy button missing no-padding styling ClipboardCopy - inline buttons missing no-padding styling Oct 22, 2024
@mcoker
Copy link
Contributor

mcoker commented Oct 22, 2024

@thatblindgeye I'm seeing the no-padding class on buttons in the inline copy clipboard variation on https://staging.patternfly.org/components/clipboard-copy#inline-compact. Are you referring to something else?

Image

@thatblindgeye
Copy link
Contributor Author

@mcoker nope that was what I was referring to, I was just viewing the staging-v6 site rather than the React specific staging. Closing this out as styling is as expected in React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants