Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review aria-hidden on react-icons imports #11197

Closed
thatblindgeye opened this issue Nov 14, 2024 · 0 comments · Fixed by #11339
Closed

Review aria-hidden on react-icons imports #11197

thatblindgeye opened this issue Nov 14, 2024 · 0 comments · Fixed by #11339
Assignees
Labels
Milestone

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
Followup related to comment #11005 (comment)

The way we are creating icons in the react-icons package, aria-hidden="true" is set by default whenever there is no title prop passed. We should review usage of icons imported and remove any hardcoded aria-hidden="true" if applicable.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 14, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Dec 5, 2024
@tlabaj tlabaj added this to the 2025.Q1 milestone Dec 5, 2024
@mfrances17 mfrances17 self-assigned this Dec 5, 2024
@mfrances17 mfrances17 moved this from Backlog to Not started in PatternFly Issues Dec 5, 2024
@mfrances17 mfrances17 modified the milestones: 2025.Q1, 2024.Q4 Dec 5, 2024
@mfrances17 mfrances17 moved this from Not started to In Progress in PatternFly Issues Dec 5, 2024
@mfrances17 mfrances17 moved this from In Progress to PR Review in PatternFly Issues Dec 9, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants