Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - charts - Victory 37.3.4 issues #11354

Open
dlabrecq opened this issue Dec 18, 2024 · 0 comments · May be fixed by #11355 or #11356
Open

Bug - charts - Victory 37.3.4 issues #11354

dlabrecq opened this issue Dec 18, 2024 · 0 comments · May be fixed by #11355 or #11356

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Dec 18, 2024 •
edited
Loading

Victory 37.3.4 generates an props.groupComponent is undefined error with our ChartBar component. In addition, Victory changed the function signature of Helpers.getPadding, which generates type errors.

The 37.3.4 packages won't build with Cost Management, due to the props.groupComponent is undefined error. And two developers have reported issues with layout -- most likely related to the padding helper function.

The workaround is to use 37.3.2 for now
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Dec 18, 2024
dlabrecq added a commit to dlabrecq/patternfly-react that referenced this issue Dec 18, 2024
@dlabrecq
fix(charts): fix Victory 37.3.4 issues
600c53e 
patternfly#11354
@dlabrecq dlabrecq linked a pull request Dec 18, 2024 that will close this issue
Open
@dlabrecq dlabrecq changed the title Bug - charts - Victory 37.3.4 issues Bug - v5 charts - Victory 37.3.4 issues Dec 18, 2024
@dlabrecq dlabrecq changed the title Bug - v5 charts - Victory 37.3.4 issues Bug - charts - Victory 37.3.4 issues Dec 18, 2024
@dlabrecq dlabrecq linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
PatternFly Issues
Status: Needs triage
Milestone
No milestone
1 participant
@dlabrecq