Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Dropdown - When dropdown opens and outer page gets overflow, scrolling down is stuck #9326

Closed
avivtur opened this issue Jul 3, 2023 · 8 comments
Assignees
Labels

Comments

@avivtur
Copy link

avivtur commented Jul 3, 2023

Describe the problem
Using the Dropdown component in a table row, causes sometimes the page to get overflow and the dropdown is getting focused on every scroll down. This happens only on firefox (installed version 113.0.1).
adding screencast below

How do you reproduce the problem?
Please note that on sandbox this works as expected and only firefox is not
https://codesandbox.io/s/xenodochial-brook-ljcmvg?file=/index.js

Expected behavior
In case the dropdown is causing the page to overflow we should be able to see the bottom of the menu (as the chrome example I posted does)

Is this issue blocking you?
Not blocking me. My workaround is using Chrome for now

Screenshots
firefox (note that I can't scroll to the bottom of the dropdown menu):

menu-scrolling-up-firefox.mp4

chrome (here everything works as expected):

menu-not-scrolling-up-chrome.mp4

What is your environment?

  • OS: fedora 36
  • Browser firefox
  • Version 103.0.1

What is your product and what release date are you targeting?

Any other information?
when the zoom is at 90% or lower this issue wasn't reproduceable for me, it was easier to reproduce on higher zoom like 110% and above

@avivtur avivtur added the bug label Jul 3, 2023
@avivtur avivtur changed the title Bug - [Component] - [short description] Bug - Dropdown - When dropdown opens and outer page gets overflow, scrolling down is stuck Jul 3, 2023
@tlabaj
Copy link
Contributor

tlabaj commented Jul 5, 2023

@avivtur What version of PF are you using?

@nicolethoen
Copy link
Contributor

It looks like the codesandbox is using the latest v4 version.
Is this something we could address in v5?

@avivtur
Copy link
Author

avivtur commented Jul 6, 2023

@nicolethoen @tlabaj Hi thanks for your reply :)
Im using PF version 4.122.2 which seems quite old

@nicolethoen
Copy link
Contributor

@tlabaj we should double check that this was indeed resolved in v5

@wise-king-sullyman
Copy link
Contributor

For whoever takes on this issue: first step should be to check if this issue is resolved for the non-deprecated dropdown. If so this issue can be closed.

@wise-king-sullyman wise-king-sullyman self-assigned this Oct 27, 2023
@wise-king-sullyman wise-king-sullyman removed this from the Prioritized Backlog milestone Oct 27, 2023
Copy link

stale bot commented Dec 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Dec 26, 2023
@stale stale bot removed the wontfix label Jan 3, 2024
@wise-king-sullyman
Copy link
Contributor

wise-king-sullyman commented Jul 4, 2024

Hi @avivtur, sorry for the delay on this, it slipped through the cracks on me.

I've tried reproducing this bug and haven't had any luck, I used your provided code snippet on firefox on fedora 39. Is this still something you're seeing?

@avivtur
Copy link
Author

avivtur commented Jul 7, 2024

@wise-king-sullyman Hi no worries :)
We moved our project to v5 and it doesn't reproduce there AFAIK

@tlabaj tlabaj closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

4 participants