You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The first part of this issue should be determining if this would be a breaking change. If so we will need to delay this fix until the next major release.
I don't think so, I think we just want to fix the type. Because the component prop is already used as React.ComponentType. You can't pass ReactNode to the prop. You will hit a runtime error.
Describe the problem
The
NavItem
component has thecomponent
prop defined as aReactNode
but then uses it in the code asReact.ComponentType
How do you reproduce the problem?
Use the NavItem
component
prop in any TS project with a custom react component (nota
or adiv
).Expected behavior
The
component
prop type should beReact.ComponentType
Is this issue blocking you?
Many workarounds:
What is your product and what release date are you targeting?
HCC, pf5 adoption starting Aug 21st, not blocking
The text was updated successfully, but these errors were encountered: