Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - PatternFly v5 drawer - background color regression #9577

Closed
dlabrecq opened this issue Sep 8, 2023 · 1 comment
Closed

Bug - PatternFly v5 drawer - background color regression #9577

dlabrecq opened this issue Sep 8, 2023 · 1 comment

Comments

@dlabrecq
Copy link
Member

dlabrecq commented Sep 8, 2023

There is a PatternFly v5 regression related to our page background color.

The drawer used with Cost Management typically has a light gray page background, but now it's white.

.pf-v5-c-drawer {
   --pf-v5-c-drawer__content--BackgroundColor: var(--pf-v5-global--BackgroundColor--100);

This is my workaround:

.drawerOverride {
  .pf-c-drawer__body {
    background-color: var(--pf-v5-global--BackgroundColor--200);
  }
}

Without the workaround
Screenshot 2023-09-08 at 9 35 08 AM

With the workaround
Screenshot 2023-09-08 at 9 34 03 AM

@dlabrecq dlabrecq added the bug label Sep 8, 2023
@dlabrecq dlabrecq changed the title Bug - PatternFly v5 drawer - background color is no longer light gray Bug - PatternFly v5 drawer - background color regression Sep 8, 2023
@dlabrecq
Copy link
Member Author

dlabrecq commented Sep 8, 2023

Met with @mcoker and we're now using colorVariant="light-200" with DrawerContent

@dlabrecq dlabrecq closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant