Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs & Nav - scroll button aria labels #9644

Open
kmcfaul opened this issue Sep 19, 2023 · 0 comments
Open

Tabs & Nav - scroll button aria labels #9644

kmcfaul opened this issue Sep 19, 2023 · 0 comments
Labels
Breaking change 💥 this change requires a major release and has API changes.
Milestone
Breaking Changes

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Sep 19, 2023 •
edited
Loading

The properties for the scroll buttons in Nav (ariaLeftScroll and ariaRightScroll) and Tabs (leftScrollAriaLabel and rightScrollAriaLabel) should use back and forward instead of left and right to better reflect what each button is doing between LTR/RTL languages.
@kmcfaul kmcfaul added Breaking change 💥 this change requires a major release and has API changes. Feature labels Sep 19, 2023
@kmcfaul kmcfaul mentioned this issue Sep 19, 2023
Merged
@wise-king-sullyman wise-king-sullyman added this to the Breaking Changes milestone Sep 22, 2023
@kmcfaul kmcfaul removed the Feature label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking change 💥 this change requires a major release and has API changes.
Projects
PatternFly Issues
Status: Backlog
Milestone
Breaking Changes
Development

No branches or pull requests
2 participants
@wise-king-sullyman @kmcfaul