Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Clipboard Copy - children typed as ReactNode, but not actually fully compatible with that type #9711

Closed
wise-king-sullyman opened this issue Oct 5, 2023 · 0 comments · Fixed by #9743
Closed

Bug - Clipboard Copy - children typed as ReactNode, but not actually fully compatible with that type #9711

wise-king-sullyman opened this issue Oct 5, 2023 · 0 comments · Fixed by #9743
Assignees
@gitdallas
Milestone
2023.Q4

Comments

@wise-king-sullyman
Copy link
Contributor

wise-king-sullyman commented Oct 5, 2023 •
edited
Loading

Describe the problem
Trying to pass a non number/string/array as the child of an expandable clipboard copy results in it being stringified to [object Object] in the "preview" area.

How do you reproduce the problem?
https://codesandbox.io/s/dazzling-kare-yh9prw?file=/index.tsx

Expected behavior
Either the type of children should be updated to reflect what is actually fully supported, or we should fix the component to actually support the possible inputs of children as it is currently typed.

Screenshots
image

Fix should be to change the type to what is actually currently supported in the component.
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Oct 5, 2023
@gitdallas gitdallas self-assigned this Oct 5, 2023
@gitdallas gitdallas mentioned this issue Oct 5, 2023
Closed
@gitdallas gitdallas removed their assignment Oct 5, 2023
@wise-king-sullyman wise-king-sullyman added this to the Prioritized Backlog milestone Oct 6, 2023
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Oct 6, 2023
@gitdallas gitdallas self-assigned this Oct 13, 2023
@gitdallas gitdallas mentioned this issue Oct 13, 2023
Merged
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2023.Q4 Oct 19, 2023
@tlabaj tlabaj moved this from Backlog to In Progress in PatternFly Issues Oct 19, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in PatternFly Issues Nov 15, 2023
@gitdallas gitdallas mentioned this issue Feb 26, 2024
Merged
@wise-king-sullyman wise-king-sullyman mentioned this issue Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitdallas gitdallas

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q4
Development

Successfully merging a pull request may close this issue.

bug(ClipboardCopy): change children type to string gitdallas/patternfly-react
3 participants
@gitdallas @wise-king-sullyman @tlabaj