Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up react hooks with missing dependencies #9812

Closed
jenny-s51 opened this issue Nov 9, 2023 · 2 comments
Closed

Clean up react hooks with missing dependencies #9812

jenny-s51 opened this issue Nov 9, 2023 · 2 comments
Labels

Comments

@jenny-s51
Copy link
Contributor

jenny-s51 commented Nov 9, 2023

Describe the enhancement or change
A clear and concise description of the request. What is the expected outcome?
There are several instances in our codebase that raise ESLint warnings where react hooks are missing dependencies from their dependency array.

Any other information?
In #9484, see warnings in DatePicker.tsx and scroll down to "Unchanged files with check annotations"

@tlabaj
Copy link
Contributor

tlabaj commented Nov 30, 2023

Lets ignore the lines of code where this is intentional.
We may need to refactor and memoize some functions.

Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2024
@stale stale bot closed this as completed Feb 13, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Feb 13, 2024
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants