Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeEditor - support Mac and PC shortcuts in example #9821

Closed
thatblindgeye opened this issue Nov 14, 2023 · 4 comments · Fixed by #10472
Closed

CodeEditor - support Mac and PC shortcuts in example #9821

thatblindgeye opened this issue Nov 14, 2023 · 4 comments · Fixed by #10472
Assignees
Labels

Comments

@thatblindgeye
Copy link
Contributor

Describe the enhancement or change
Followup to updates made to a11y docs and conversation at patternfly/patternfly-org#3799 (comment)

The with shortcut menu and main header content example is setup to only render a list of keys as A + B + C + n.... It'd be beneficial to have the example show the shortcuts menu supporting both Mac and PC shortcuts.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

@thatblindgeye thatblindgeye changed the title CoedEditor - support Mac and PC shortcuts in example CodeEditor - support Mac and PC shortcuts in example Nov 14, 2023
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Nov 14, 2023
@wise-king-sullyman wise-king-sullyman moved this from Needs triage to Backlog in PatternFly Issues Nov 14, 2023
Copy link

stale bot commented Jan 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2024
Copy link

stale bot commented Apr 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Apr 11, 2024
Copy link

false

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in PatternFly Issues Apr 25, 2024
@thatblindgeye thatblindgeye reopened this Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Apr 25, 2024
@github-actions github-actions bot removed the wontfix label Apr 27, 2024
@tlabaj tlabaj added the Pinned label May 2, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues May 2, 2024
@tlabaj
Copy link
Contributor

tlabaj commented May 2, 2024

Lets add a checkbox to toggle between Mac and PC shortcuts.

@tlabaj tlabaj added the sm label May 2, 2024
@Dominik-Petrik Dominik-Petrik self-assigned this May 22, 2024
@Dominik-Petrik Dominik-Petrik moved this from Backlog to PR Review in PatternFly Issues May 29, 2024
@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Jun 25, 2024
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants